-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.11.0 #62
Release 0.11.0 #62
Conversation
akaila-splunk
commented
Jul 23, 2021
- Update all dependencies to latest stable version and replace deprecated dependencies
- make library compatible with node version 10.0 and 14.0 and Splunk version 8.0 and 8.2.0
- Configured GitHub action for test and release
- Update library to use 'make up' and 'make test' convention
Add NodeJS and Splunk versions tested for compatibility https://jira.splunk.com/browse/DVPL-7485
Revise README
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.0.12 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.0.12...v4.5.3) Signed-off-by: dependabot[bot] <[email protected]>
…-4.5.3 Bump handlebars from 4.0.12 to 4.5.3
Revise link to contact us (no more [email protected]).
…er instance Dockerized make up, make test commands for local and CI -- makefile, docker-compose.yml, test_specific.sh Upgraded dependencies Replaced deprecated dependencies such as "request" and "istanbul" with "needle" and "nyc"
Dependency upgrades with Project updated to use Make with Splunk docker instance As discussed, merging this PR based on one Approval
GitHub actions for Test execution
Extra on property
Trying with passing value to makefile
- Testing release to NPM using GitHub action for v0.0.1-beta
Configured GitHub Action for Test Execution
Configured GitHub actions for release to NPM
Update CONTRIBUTING.md
CREDITS.md file added along with Node 10.0 version addition in the CI matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, I left comments in the review but two things to take care of:
- Need to add a new section to the CHANGELOG.md for this new release (notes on what to add to various sections are in the review below)
- Let's remove the .travis.yml since that's no longer used
@@ -14,7 +14,7 @@ | |||
* under the License. | |||
*/ | |||
|
|||
var request = require("request"); | |||
var needle = require("needle"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's add an item to the CHANGELOG.md for this - under
New features & APIs
: Replaced client implementation to useneedle
in lieu of deprecatedrequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated CHANGELOG.md file as suggested.
@@ -0,0 +1,20 @@ | |||
name: Create Release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's add an item to the CHANGELOG.md for this - under
Minor changes
: Converted CI from Travis to Github Actions and added CD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated CHANGELOG.md file as suggested.
.travis.yml
Outdated
@@ -10,7 +10,7 @@ before_install: | |||
# Create .splunkrc file with default credentials | |||
- echo host=localhost >> $HOME/.splunkrc | |||
- echo username=admin >> $HOME/.splunkrc | |||
- echo password=changeme >> $HOME/.splunkrc | |||
- echo password=changed! >> $HOME/.splunkrc | |||
# Set SPLUNK_HOME | |||
- export SPLUNK_HOME="/opt/splunk" | |||
# Pull docker image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the .travis.yml file actually? Feel free to do that in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed .travis.yml flie.
Updated CHANGELOG.md file as suggested and removed .travis.yml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks again!